src/grung/db.py

@@ -1,12 +1,8 @@
 import inspect
-import re
-from functools import reduce
-from operator import ior
 
-from tinydb import Query, TinyDB, table
+from tinydb import TinyDB, table
 from tinydb.table import Document
 
-from grung.exceptions import UniqueConstraintError
 from grung.types import Record
 
 
@@ -15,10 +11,9 @@ class RecordTable(table.Table):
     Wrapper around tinydb Tables that handles Records instead of dicts.
     """
 
-    def __init__(self, name: str, db: TinyDB, document_class: Document = Record, **kwargs):
+    def __init__(self, storage, name, document_class: Document = Record, **kwargs):
         self.document_class = document_class
-        self._db = db
+        super().__init__(storage, name, **kwargs)
-        super().__init__(db.storage, name, **kwargs)
 
     def insert(self, document):
         self._satisfy_constraints(document)
@@ -32,26 +27,9 @@ class RecordTable(table.Table):
         if document.doc_id:
             super().remove(doc_ids=[document.doc_id])
 
-    def _satisfy_constraints(self, document) -> bool:
+    def _satisfy_constraints(self, document):
-        self._check_unique(document)
+        # check for uniqueness, etc.
-
+        pass
-    def _check_unique(self, document) -> bool:
-        matches = [
-            match
-            for match in self.search(
-                reduce(
-                    ior,
-                    [
-                        Query()[field.name].matches(document[field.name], flags=re.IGNORECASE)
-                        for field in document._metadata.fields.values()
-                        if field.unique
-                    ],
-                )
-            )
-            if match.doc_id != document.doc_id
-        ]
-        if matches != []:
-            raise UniqueConstraintError(document, matches)
 
 
 class GrungDB(TinyDB):
@@ -75,7 +53,7 @@ class GrungDB(TinyDB):
     def create_table(self, table_class):
         name = table_class.__name__
         if name not in self._tables:
-            self._tables[name] = RecordTable(name, db=self, document_class=table_class)
+            self._tables[name] = RecordTable(self.storage, name, document_class=table_class)
         return self.table(name)
 
     def save(self, record):

src/grung/exceptions.py

@@ -1,12 +0,0 @@
-class UniqueConstraintError(Exception):
-    """
-    Thrown when a db write operation cannot complete due to a field's unique constraint.
-    """
-
-    def __init__(self, document, collisions):
-        super().__init__(
-            "\n"
-            f"  * Record:  {dict(document)}\n"
-            f"  * Error:   Unique constraint failure\n"
-            "   * The record matches the following existing records:\n\n" + "\n".join(str(c) for c in collisions)
-        )

test/test_db.py

@@ -3,7 +3,6 @@ from tinydb.storages import MemoryStorage
 
 from grung import examples
 from grung.db import GrungDB
-from grung.exceptions import UniqueConstraintError
 
 
 @pytest.fixture
@@ -50,13 +49,3 @@ def test_crud(db):
     # delete
     db.delete(players)
     assert len(db.Group) == 0
-
-
-def test_unique(db):
-    user1 = examples.User(name="john", email="john@foo")
-    user2 = examples.User(name="john", email="john@foo")
-
-    user1 = db.save(user1)
-    with pytest.raises(UniqueConstraintError):
-        user2 = db.save(user2)
-    db.save(user1)